Skip to content

bump runc v1.0.0-rc8-32-gf4982d86#3372

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_runc
Jun 25, 2019
Merged

bump runc v1.0.0-rc8-32-gf4982d86#3372
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_runc

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jun 25, 2019 •
edited
Loading

full diff: opencontainers/runc@v1.0.0-rc8...f4982d8

possibly relevant changes included:

Signed-off-by: Sebastiaan van Stijn [email protected]

@thaJeztah
bump runc v1.0.0-rc8-32-gf4982d86
cb4a8f5 
full diff: opencontainers/runc@v1.0.0-rc8...f4982d8

possibly relevant changes included:

- opencontainers/runc#2074 Update dependency libseccomp-golang
  - fixes https://nvd.nist.gov/vuln/detail/CVE-2017-18367
- opencontainers/runc#2065 Fix cgroup hugetlb size prefix for kB
- opencontainers/runc#2042 libcontainer: intelrdt: add missing destroy handler in defer func
- opencontainers/runc#2042 main: not reopen /dev/stderr
- opencontainers/runc#2038 `r.destroy` can defer exec in `runner.run` method
- opencontainers/runc#2035 specconv: always set "type: bind" in case of MS_BIND
- opencontainers/runc#2035 Move systemd.Manager initialization into a function in that module
- opencontainers/runc#2034 Support for logging from children processes

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 25, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 25, 2019

Codecov Report

Merging #3372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3372   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files         113      113           
  Lines       12542    12542           
=======================================
  Hits         5654     5654           
  Misses       6032     6032           
  Partials      856      856
Flag Coverage Δ
#linux 49.01% <ø> (ø) ⬆️
#windows 40.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2875825...cb4a8f5. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 25, 2019 •
edited
Loading

Codecov Report

Merging #3372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3372   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files         113      113           
  Lines       12542    12542           
=======================================
  Hits         5654     5654           
  Misses       6032     6032           
  Partials      856      856
Flag Coverage Δ
#linux 49.01% <ø> (ø) ⬆️
#windows 40.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2875825...cb4a8f5. Read the comment docs.

estesp
estesp approved these changes Jun 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 25, 2019

FWIW, I asked if the CVE warrants a new RC for runc (I'm not exactly sure how severe the issue is); opencontainers/runc#2074 (comment)

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Jun 25, 2019

LGTM

@crosbymichael crosbymichael merged commit 5b4ed0d into containerd:master Jun 25, 2019
@odinuge odinuge mentioned this pull request Jun 25, 2019
Closed
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 25, 2019

opencontainers/runc#2074 (comment)

Looks like the fix for the CVE was already merged in opencontainers/runc@03a5a74#diff-c1eca12d097b318b217f891966083c8e as part of opencontainers/runc#1424

The "diff" posted in this PR looks to be between the wrong commits; this is the right link/diff:

seccomp/libseccomp-golang@84e90a9...v0.9.1

@thaJeztah thaJeztah deleted the bump_runc branch June 25, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

+1 more reviewer

@justincormack justincormack justincormack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @codecov-io @crosbymichael @justincormack @estesp