Skip to content

Fix shim's file IO logging#3370

Merged
estesp merged 1 commit intocontainerd:masterfrom
mxpv:file-io
Jun 25, 2019
Merged

Fix shim's file IO logging#3370
estesp merged 1 commit intocontainerd:masterfrom
mxpv:file-io

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Jun 24, 2019

In current implementation the shim attempts to open a URI file path for logging and fails with something like:

$ sudo ctr run --log-uri file:///tmp/1.txt docker.io/library/hello-world:latest hello1
ctr: failed to start io pipe copy: unable to copy pipes: containerd-shim: opening file "file:///tmp/1.txt" failed: open file:///tmp/1.txt: no such file or directory: unknown

Signed-off-by: Maksym Pavlenko [email protected]

Signed-off-by: Maksym Pavlenko <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 24, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3370   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files         113      113           
  Lines       12542    12542           
=======================================
  Hits         5654     5654           
  Misses       6032     6032           
  Partials      856      856
Flag Coverage Δ
#linux 49.01% <ø> (ø) ⬆️
#windows 40.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88362f...174c490. Read the comment docs.

2 similar comments
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3370   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files         113      113           
  Lines       12542    12542           
=======================================
  Hits         5654     5654           
  Misses       6032     6032           
  Partials      856      856
Flag Coverage Δ
#linux 49.01% <ø> (ø) ⬆️
#windows 40.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88362f...174c490. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3370   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files         113      113           
  Lines       12542    12542           
=======================================
  Hits         5654     5654           
  Misses       6032     6032           
  Partials      856      856
Flag Coverage Δ
#linux 49.01% <ø> (ø) ⬆️
#windows 40.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88362f...174c490. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit b2662f2 into containerd:master Jun 25, 2019
@mxpv mxpv deleted the file-io branch November 26, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants