Skip to content

Reserve exec id to prevent race#3365

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:exec-lk
Jun 25, 2019
Merged

Reserve exec id to prevent race#3365
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:exec-lk

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

ref #2820

cc @lifubang

Signed-off-by: Michael Crosby [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 21, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 21, 2019

Codecov Report

Merging #3365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3365   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files         113      113           
  Lines       12542    12542           
=======================================
  Hits         5654     5654           
  Misses       6032     6032           
  Partials      856      856
Flag Coverage Δ
#linux 49.01% <ø> (ø) ⬆️
#windows 40.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88362f...1a8df3f. Read the comment docs.

Comment thread runtime/v2/runc/v1/service.go
Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor NIT. LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 2875825 into containerd:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants