[release/1.2] Close socket fd#3364
Merged
fuweid merged 1 commit intocontainerd:release/1.2from Jun 21, 2019
keloyang:close-socket-fd-1.2
Merged
[release/1.2] Close socket fd#3364fuweid merged 1 commit intocontainerd:release/1.2from keloyang:close-socket-fd-1.2
fuweid merged 1 commit intocontainerd:release/1.2from
keloyang:close-socket-fd-1.2
Conversation
containerd-shim has dup the fd 3, and it don't need fd 3 any more. Signed-off-by: Shukui Yang <[email protected]>
keloyang
changed the title
Member
|
@keloyang thanks for cherry-pick. it seems that something is hang in CI. could you please to re-push it to trigger it again? thanks |
Member
|
We had a flaky test failure--I just restarted the broken CI runs, so it should be ok :) |
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3364 +/- ##
============================================
Coverage 43.81% 43.81%
============================================
Files 101 101
Lines 10780 10780
============================================
Hits 4723 4723
Misses 5321 5321
Partials 736 736
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of #3359 to release/1.2.
Signed-off-by: Shukui Yang [email protected]