Add timeout in load shim v2#3355
Merged
estesp merged 1 commit intocontainerd:masterfrom Jun 19, 2019
Merged
Conversation
add timeout in connect shim v2 avoid starting containerd hang Signed-off-by: Ace-Tang <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3355 +/- ##
=======================================
Coverage 44.75% 44.75%
=======================================
Files 113 113
Lines 12513 12513
=======================================
Hits 5600 5600
Misses 6057 6057
Partials 856 856
Continue to review full report at Codecov.
|
Contributor
|
LGTM |
Member
|
We should watch this change and do some stress testing for machines under load. Timeouts are hard because systems under heavy load can block for a while and apparently users are ok with it :( |
Contributor
Author
|
It hard to judge shim hang because of system or lock in shim or others, how about skip cleanupDeadShim if get Timeout error @crosbymichael |
Ace-Tang
added a commit
to Ace-Tang/containerd
that referenced
this pull request
Jul 3, 2019
base on containerd#3355 Signed-off-by: Ace-Tang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add timeout in connect shim v2 avoid starting containerd hang
Signed-off-by: Ace-Tang [email protected]