Skip to content

Fix snapshotter getter in client code#3352

Merged
jterry75 merged 1 commit intocontainerd:masterfrom
crosbymichael:sn-panic
Jun 17, 2019
Merged

Fix snapshotter getter in client code#3352
jterry75 merged 1 commit intocontainerd:masterfrom
crosbymichael:sn-panic

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Fixes #3312

Signed-off-by: Michael Crosby [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 17, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3352   +/-   ##
=======================================
  Coverage   44.75%   44.75%           
=======================================
  Files         113      113           
  Lines       12513    12513           
=======================================
  Hits         5600     5600           
  Misses       6057     6057           
  Partials      856      856
Flag Coverage Δ
#linux 48.65% <ø> (ø) ⬆️
#windows 40.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb108e...41e1bb8. Read the comment docs.

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75 jterry75 merged commit 3e7c6f6 into containerd:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic / v1alpha2._RuntimeService / SIGSEGV code=0x1 addr=0x38 pc=0x55f266891275

4 participants