Make newBinaryIO public#3348
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Jun 16, 2019
Merged
Conversation
Allow third-party runtime implementations to reuse NewBinaryIO in order to support pluggable shim logging binary protocol. Signed-off-by: Maksym Pavlenko <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3348 +/- ##
=======================================
Coverage 44.75% 44.75%
=======================================
Files 113 113
Lines 12513 12513
=======================================
Hits 5600 5600
Misses 6057 6057
Partials 856 856
Continue to review full report at Codecov.
|
Member
|
LGTM |
Contributor
|
LGTM (not a maintainer, but I find this useful) |
AkihiroSuda
approved these changes
Jun 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
func newBinaryIO(...) (runc.IO, error)public so third-party runtimescan reuse it for binary shim logging (and use in conjunction with
logging.Run(...)).Signed-off-by: Maksym Pavlenko [email protected]