Skip to content

Ensure labels is not nil in differ#3345

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:diff-panic
Jun 14, 2019
Merged

Ensure labels is not nil in differ#3345
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:diff-panic

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Signed-off-by: Michael Crosby [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 14, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3345   +/-   ##
=======================================
  Coverage   44.75%   44.75%           
=======================================
  Files         113      113           
  Lines       12513    12513           
=======================================
  Hits         5600     5600           
  Misses       6057     6057           
  Partials      856      856
Flag Coverage Δ
#linux 48.65% <ø> (ø) ⬆️
#windows 40.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50cd49d...0525515. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 062d056 into containerd:master Jun 14, 2019
@crosbymichael crosbymichael deleted the diff-panic branch June 14, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants