Unmount rootfs with separate Remove() in bundle#3325
Merged
fuweid merged 1 commit intocontainerd:masterfrom Jun 6, 2019
Merged
Unmount rootfs with separate Remove() in bundle#3325fuweid merged 1 commit intocontainerd:masterfrom
fuweid merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
This ensures that a container does not have a mounted rootfs in the bundle directory before RemoveAll is called. Having the rootfs removed first with a Remove ensures that the directory is not mounted and empty before the bundle directory is removed. Signed-off-by: Michael Crosby <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3325 +/- ##
=======================================
Coverage 44.86% 44.86%
=======================================
Files 113 113
Lines 12338 12338
=======================================
Hits 5535 5535
Misses 5953 5953
Partials 850 850
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that a container does not have a mounted rootfs in the
bundle directory before RemoveAll is called. Having the rootfs removed
first with a Remove ensures that the directory is not mounted and empty
before the bundle directory is removed.
Signed-off-by: Michael Crosby [email protected]