Skip to content

Ensure close in content test#3324

Merged
crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael:content-close
Jun 5, 2019
Merged

Ensure close in content test#3324
crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael:content-close

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael commented Jun 4, 2019

This helps some failures in the windows CI

Signed-off-by: Michael Crosby [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 4, 2019

Build succeeded.

Signed-off-by: Michael Crosby <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 4, 2019

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 4, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3324 into master will increase coverage by <.01%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3324      +/-   ##
==========================================
+ Coverage   44.85%   44.86%   +<.01%     
==========================================
  Files         113      113              
  Lines       12326    12338      +12     
==========================================
+ Hits         5529     5535       +6     
- Misses       5949     5953       +4     
- Partials      848      850       +2
Flag Coverage Δ
#linux 48.79% <63.63%> (+0.01%) ⬆️
#windows 40.25% <53.84%> (+0.01%) ⬆️
Impacted Files Coverage Δ
content/local/store.go 49.52% <53.84%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e7747...4a2819d. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 4, 2019

Codecov Report

Merging #3324 into master will increase coverage by <.01%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3324      +/-   ##
==========================================
+ Coverage   44.85%   44.86%   +<.01%     
==========================================
  Files         113      113              
  Lines       12326    12338      +12     
==========================================
+ Hits         5529     5535       +6     
- Misses       5949     5953       +4     
- Partials      848      850       +2
Flag Coverage Δ
#linux 48.79% <63.63%> (+0.01%) ⬆️
#windows 40.25% <53.84%> (+0.01%) ⬆️
Impacted Files Coverage Δ
content/local/store.go 49.52% <53.84%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e7747...cf7fb14. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread content/local/store.go Outdated
Signed-off-by: Michael Crosby <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 5, 2019

Build succeeded.

@ehazlett
Copy link
Copy Markdown
Member

ehazlett commented Jun 5, 2019

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants