Skip to content

Update ttrpc for metadata and namespace support#3321

Merged
estesp merged 2 commits intocontainerd:masterfrom
crosbymichael:ttrpc-namespace
Jun 4, 2019
Merged

Update ttrpc for metadata and namespace support#3321
estesp merged 2 commits intocontainerd:masterfrom
crosbymichael:ttrpc-namespace

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

No description provided.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 4, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3321 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3321      +/-   ##
==========================================
+ Coverage   44.83%   44.87%   +0.04%     
==========================================
  Files         112      113       +1     
  Lines       12311    12320       +9     
==========================================
+ Hits         5520     5529       +9     
  Misses       5943     5943              
  Partials      848      848
Flag Coverage Δ
#linux 48.81% <100%> (+0.04%) ⬆️
#windows 40.26% <100%> (+0.05%) ⬆️
Impacted Files Coverage Δ
namespaces/ttrpc.go 100% <100%> (ø)
namespaces/context.go 55.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa5f55...fa6a9f0. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3321 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3321      +/-   ##
==========================================
+ Coverage   44.83%   44.87%   +0.04%     
==========================================
  Files         112      113       +1     
  Lines       12311    12320       +9     
==========================================
+ Hits         5520     5529       +9     
  Misses       5943     5943              
  Partials      848      848
Flag Coverage Δ
#linux 48.81% <100%> (+0.04%) ⬆️
#windows 40.26% <100%> (+0.05%) ⬆️
Impacted Files Coverage Δ
namespaces/ttrpc.go 100% <100%> (ø)
namespaces/context.go 55.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa5f55...fa6a9f0. Read the comment docs.

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants