Skip to content

Fix run with specified platform#3301

Merged
fuweid merged 1 commit intocontainerd:masterfrom
dmcgowan:add-run-platform
May 23, 2019
Merged

Fix run with specified platform#3301
fuweid merged 1 commit intocontainerd:masterfrom
dmcgowan:add-run-platform

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Adds the platform flag to the run command and resolves the image based on that platform.

Adds the platform flag to the run command and resolves
the image based on that platform.

Signed-off-by: Derek McGowan <[email protected]>
Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 23, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3301 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3301   +/-   ##
======================================
  Coverage    44.6%   44.6%           
======================================
  Files         112     112           
  Lines       12180   12180           
======================================
  Hits         5433    5433           
  Misses       5913    5913           
  Partials      834     834
Flag Coverage Δ
#linux 48.49% <ø> (ø) ⬆️
#windows 39.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25daa73...a274dbe. Read the comment docs.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented May 23, 2019

1 Reviewer + 1 Maintainer . Merging

@fuweid fuweid merged commit 290fc9e into containerd:master May 23, 2019
@dmcgowan dmcgowan deleted the add-run-platform branch September 10, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants