Skip to content

Forcibly sync writes on lcow layer.vhd after write#3298

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
jterry75:sync_tar2ext4_write
May 24, 2019
Merged

Forcibly sync writes on lcow layer.vhd after write#3298
dmcgowan merged 1 commit intocontainerd:masterfrom
jterry75:sync_tar2ext4_write

Conversation

@jterry75
Copy link
Copy Markdown
Contributor

Signed-off-by: Justin Terry (VM) [email protected]

@jterry75
Copy link
Copy Markdown
Contributor Author

@jstarks - FYI

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 22, 2019

Build succeeded.

@jterry75
Copy link
Copy Markdown
Contributor Author

@crosbymichael - I don't understand how to triage a failure like this. What does the makefile failure indicate?

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3298 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3298   +/-   ##
======================================
  Coverage    44.6%   44.6%           
======================================
  Files         112     112           
  Lines       12180   12180           
======================================
  Hits         5433    5433           
  Misses       5913    5913           
  Partials      834     834
Flag Coverage Δ
#linux 48.49% <ø> (ø) ⬆️
#windows 39.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25daa73...e0c4fe4. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 0e7a3c9 into containerd:master May 24, 2019
@jterry75 jterry75 deleted the sync_tar2ext4_write branch May 24, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants