Use a single custom annotation for export#3296
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom May 22, 2019
Merged
Use a single custom annotation for export#3296crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
dmcgowan
force-pushed
the
fix-export-labels
branch
2 times, most recently
from
dcc2169 to
5e2d7ef
Compare
Remove annotation prefix and add multiple index records for manifests with multiple image names. This makes the custom annotation more consistent with the OCI image annotation. Additionally, ensure the OCI image annotation always represents the tag (partial image name) as recommended by the specification. The containerd image name annotation will always contain the full image name. Signed-off-by: Derek McGowan <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3296 +/- ##
=======================================
Coverage 44.62% 44.62%
=======================================
Files 112 112
Lines 12174 12174
=======================================
Hits 5433 5433
Misses 5907 5907
Partials 834 834
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
May 22, 2019
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove annotation prefix and add multiple index records
for manifests with multiple image names. This makes the
custom annotation more consistent with the OCI ref name
annotation. Additionally, ensure the OCI image annotation
always represents the tag (partial image name) as recommended
by the specification. The containerd image name annotation
will always contain the full image name.