Improve atomic delete#3293
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom May 21, 2019
Merged
Conversation
skip hidden directories in load task, and return soon if path not exist in atomicDelete carry of containerd#3233 Closes containerd#3233 Signed-off-by: Ace-Tang <[email protected]> Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
atomic-delete
branch
from
5102385 to
5b7a327
Compare
Member
Author
|
LGTM carry updating the error handling from code review |
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3293 +/- ##
======================================
Coverage 44.4% 44.4%
======================================
Files 113 113
Lines 12231 12231
======================================
Hits 5431 5431
Misses 5966 5966
Partials 834 834
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip hidden directories in load task, and return soon if path not exist
in atomicDelete
carry of #3233
Closes #3233
Signed-off-by: Ace-Tang [email protected]
Signed-off-by: Michael Crosby [email protected]