ctr: make ctr shim command easy to use#3288
Merged
estesp merged 1 commit intocontainerd:masterfrom May 17, 2019
Merged
Conversation
|
Build succeeded.
|
mxpv
reviewed
May 16, 2019
Member
There was a problem hiding this comment.
Can this be just shim.SocketAddress(ctx, id) ?
containerd/runtime/v2/shim/util_unix.go
Line 56 in cd5369b
make ctr shim command easy to use for user, shim socket is generated through sha256, and it can not get directly, change socket flag to id command, generated socket in code. It also avoid fail to connect shim v2, since shim v2 have multiple containers, `ctr shim --socket state` should specify container id, or get error `rpc error: code = NotFound desc = container not created: not found` Signed-off-by: Ace-Tang <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3288 +/- ##
======================================
Coverage 44.4% 44.4%
======================================
Files 113 113
Lines 12231 12231
======================================
Hits 5431 5431
Misses 5966 5966
Partials 834 834
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make ctr shim command easy to use for user, shim socket is generated
through sha256, and it can not get directly, change socket flag to id
command, generated socket in code.
It also avoid fail to connect shim v2, since shim v2 have multiple
containers,
ctr shim --socket stateshould specify container id, orget error
rpc error: code = NotFound desc = container not created: not foundSigned-off-by: Ace-Tang [email protected]