Skip to content

Remove unused Resize method from initState#3280

Merged
estesp merged 1 commit intocontainerd:masterfrom
jterry75:init_state_resize_unused
May 14, 2019
Merged

Remove unused Resize method from initState#3280
estesp merged 1 commit intocontainerd:masterfrom
jterry75:init_state_resize_unused

Conversation

@jterry75
Copy link
Copy Markdown
Contributor

Signed-off-by: Justin Terry (VM) [email protected]

@jterry75 jterry75 requested a review from crosbymichael May 13, 2019 19:35
@jterry75
Copy link
Copy Markdown
Contributor Author

@crosbymichael - This code was misleading. It made it appear like an execState and initState operated the same way on a Resize in the stoppedState but in fact they do not. func (p *Init) Resize does not use p.initState.Resize at all so exec vs init are different. I believe this is because we want to keep the tty around as long as a runc delete has not been called but since there is no delete call for an exec it needs to be cleaned up at transition. Do you agree?

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 13, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3280 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3280   +/-   ##
======================================
  Coverage    44.4%   44.4%           
======================================
  Files         113     113           
  Lines       12231   12231           
======================================
  Hits         5431    5431           
  Misses       5966    5966           
  Partials      834     834
Flag Coverage Δ
#linux 48.33% <ø> (ø) ⬆️
#windows 39.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7acdb16...5e962dd. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3280 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3280   +/-   ##
======================================
  Coverage    44.4%   44.4%           
======================================
  Files         113     113           
  Lines       12231   12231           
======================================
  Hits         5431    5431           
  Misses       5966    5966           
  Partials      834     834
Flag Coverage Δ
#linux 48.33% <ø> (ø) ⬆️
#windows 39.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7acdb16...5e962dd. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 5158bc8 into containerd:master May 14, 2019
@jterry75 jterry75 deleted the init_state_resize_unused branch May 14, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants