containerd-shim: redirect output into stdout fifo#3275
Merged
estesp merged 1 commit intocontainerd:masterfrom May 13, 2019
Merged
containerd-shim: redirect output into stdout fifo#3275estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Redirect is used to make sure that containerd still can read the log of shim after restart. Signed-off-by: Wei Fu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3275 +/- ##
=========================================
- Coverage 48.33% 44.4% -3.93%
=========================================
Files 102 113 +11
Lines 9627 12231 +2604
=========================================
+ Hits 4653 5431 +778
- Misses 4149 5966 +1817
- Partials 825 834 +9
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redirect is used to make sure that containerd still can read the log of
shim after restart.
Signed-off-by: Wei Fu [email protected]