ctr images import: add --no-unpack option#3259
Conversation
|
cc @Random-Liu I'm not sure if this is the right naming convention etc. or what else I should do, but the change is so trivial that I went ahead and filed it after reading CONTRIBUTING.md and filing #3258 😅 |
Codecov Report
@@ Coverage Diff @@
## master #3259 +/- ##
==========================================
- Coverage 44.63% 44.61% -0.03%
==========================================
Files 113 113
Lines 12164 12219 +55
==========================================
+ Hits 5430 5451 +21
- Misses 5899 5932 +33
- Partials 835 836 +1
Continue to review full report at Codecov.
|
Signed-off-by: Benjamin Elder <[email protected]>
|
There are other jobs failing with the same error and this patch doesn't seem to be related to the error, is it possible that the test is flaky? how can we retrigger the failed job? |
|
LGTM |
|
@BenTheElder you can push again to rerun the CI 😂 Basically, your change is not related to the flaky test case. But we need the CI green. |
|
All green now; I restarted the Windows CI
|
|
Thanks all! 🙂
*From: *Phil Estes <[email protected]>
*Date: *Sun, May 5, 2019 at 12:29 PM
*To: *containerd/containerd
*Cc: *Benjamin Elder, Mention
Merged #3259 <#3259> into
… master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3259 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHADK25JS5G354QDH73RP3PT4YTLANCNFSM4HJRYYIA>
.
|
7 participants
Implements #3258.
ctr images import ...with the new--no-unpackoption will return afterImport, skipping imageUnpack.This can be used to import images into the content store for E.G. VM image baking without unpacking them to a snapshotter.
Signed-off-by: Benjamin Elder [email protected]