Skip to content

Remove redundant error checks#3256

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
dvrkps:redundant
May 3, 2019
Merged

Remove redundant error checks#3256
dmcgowan merged 1 commit intocontainerd:masterfrom
dvrkps:redundant

Conversation

@dvrkps
Copy link
Copy Markdown
Contributor

@dvrkps dvrkps commented Apr 30, 2019

Signed-off-by: Davor Kapsa [email protected]

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 30, 2019

Codecov Report

Merging #3256 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3256      +/-   ##
==========================================
+ Coverage   44.63%   44.66%   +0.02%     
==========================================
  Files         113      113              
  Lines       12164    12156       -8     
==========================================
  Hits         5430     5430              
+ Misses       5899     5893       -6     
+ Partials      835      833       -2
Flag Coverage Δ
#linux 48.68% <66.66%> (+0.03%) ⬆️
#windows 39.9% <50%> (+0.02%) ⬆️
Impacted Files Coverage Δ
services/server/server.go 1.26% <0%> (+0.01%) ⬆️
metadata/content.go 44.18% <100%> (+0.2%) ⬆️
snapshots/devmapper/metadata.go 66.41% <100%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17c809...cfc3638. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer)

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit c10eb8d into containerd:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants