Skip to content

Use cancel on errors#3255

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
dvrkps:usecancel
May 7, 2019
Merged

Use cancel on errors#3255
crosbymichael merged 1 commit intocontainerd:masterfrom
dvrkps:usecancel

Conversation

@dvrkps
Copy link
Copy Markdown
Contributor

@dvrkps dvrkps commented Apr 30, 2019

Signed-off-by: Davor Kapsa [email protected]

Signed-off-by: Davor Kapsa <[email protected]>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 30, 2019

Codecov Report

Merging #3255 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3255   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files         113      113           
  Lines       12164    12164           
=======================================
  Hits         5430     5430           
  Misses       5899     5899           
  Partials      835      835
Flag Coverage Δ
#linux 48.65% <ø> (ø) ⬆️
#windows 39.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5a424...38e3696. Read the comment docs.

@dmcgowan dmcgowan requested a review from crosbymichael May 6, 2019 22:39
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael crosbymichael merged commit 5cf1356 into containerd:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants