Skip to content

Stop logging error on v2 multi shim log failure#3252

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
jterry75:remove_log_connect_error
May 4, 2019
Merged

Stop logging error on v2 multi shim log failure#3252
dmcgowan merged 1 commit intocontainerd:masterfrom
jterry75:remove_log_connect_error

Conversation

@jterry75
Copy link
Copy Markdown
Contributor

Signed-off-by: Justin Terry (VM) [email protected]

@jterry75 jterry75 requested a review from crosbymichael April 30, 2019 18:21
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 30, 2019

Codecov Report

Merging #3252 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3252   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files         113      113           
  Lines       12164    12164           
=======================================
  Hits         5430     5430           
  Misses       5899     5899           
  Partials      835      835
Flag Coverage Δ
#linux 48.65% <ø> (ø) ⬆️
#windows 39.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5a424...969035b. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3252 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3252   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files         113      113           
  Lines       12164    12164           
=======================================
  Hits         5430     5430           
  Misses       5899     5899           
  Partials      835      835
Flag Coverage Δ
#linux 48.65% <ø> (ø) ⬆️
#windows 39.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5a424...969035b. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 82f2ac7 into containerd:master May 4, 2019
@jterry75 jterry75 deleted the remove_log_connect_error branch November 4, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants