[release/1.2 backport] Update ttrpc#3250
Merged
dmcgowan merged 2 commits intocontainerd:release/1.2from May 6, 2019
Merged
Conversation
Signed-off-by: Brian Goff <[email protected]> (cherry picked from commit 0befa45) Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: containerd/ttrpc@f02858b...699c4e4 - containerd/ttrpc#33 Fix returns error message - containerd/ttrpc#35 Make onclose an option Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 8c5779c) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3250 +/- ##
============================================
Coverage 43.74% 43.74%
============================================
Files 101 101
Lines 10743 10743
============================================
Hits 4700 4700
Misses 5311 5311
Partials 732 732
Continue to review full report at Codecov.
|
Member
|
There was a patch needed in containerd to not send timeouts through ttrpc for certain cases. |
Member
|
Here it is: #2944 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports of;