Skip to content

Bump runc 1.0.0-rc8, opencontainers/selinux v1.2.2#3240

Merged
estesp merged 2 commits intocontainerd:masterfrom
thaJeztah:bump_runc_1.0.0-rc.8
Apr 28, 2019
Merged

Bump runc 1.0.0-rc8, opencontainers/selinux v1.2.2#3240
estesp merged 2 commits intocontainerd:masterfrom
thaJeztah:bump_runc_1.0.0-rc.8

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 26, 2019

runc v1.0.0-rc8 wasn't tagged yet, but took the commit of the version bump

@tao12345666333
Copy link
Copy Markdown
Contributor

full diff: opencontainers/runc@029124d...425e105

- opencontainers/runc#2043 Vendor in latest selinux code for keycreate errors

Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: opencontainers/selinux@v1.2.1...v1.2.2

- opencontainers/selinux#51 Older kernels do not support keyring labeling

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the bump_runc_1.0.0-rc.8 branch from bd4ac93 to e5aab17 Compare April 26, 2019 05:43
Copy link
Copy Markdown
Contributor

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3240 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3240      +/-   ##
=========================================
+ Coverage   44.63%   44.7%   +0.07%     
=========================================
  Files         113     113              
  Lines       12162   12181      +19     
=========================================
+ Hits         5428    5446      +18     
+ Misses       5899    5896       -3     
- Partials      835     839       +4
Flag Coverage Δ
#linux 48.65% <ø> (ø) ⬆️
#windows 39.87% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
content/local/writer.go 63.63% <0%> (+5.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810b3c3...e5aab17. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants