Skip to content

[release/1.2] cherry-pick: Convert Windows CI to use Microsoft MCR image urls#3235

Merged
estesp merged 1 commit intocontainerd:release/1.2from
estesp:update-to-ms-image
Apr 19, 2019
Merged

[release/1.2] cherry-pick: Convert Windows CI to use Microsoft MCR image urls#3235
estesp merged 1 commit intocontainerd:release/1.2from
estesp:update-to-ms-image

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Apr 19, 2019

Cherrypick #3230 commit (e6fc0ed)

Signed-off-by: Justin Terry (VM) [email protected]
Signed-off-by: Phil Estes [email protected]

Signed-off-by: Justin Terry (VM) <[email protected]>
Signed-off-by: Phil Estes <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3235 into release/1.2 will decrease coverage by 3.63%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #3235      +/-   ##
===============================================
- Coverage        47.38%   43.74%   -3.64%     
===============================================
  Files               92      101       +9     
  Lines             8408    10743    +2335     
===============================================
+ Hits              3984     4700     +716     
- Misses            3698     5311    +1613     
- Partials           726      732       +6
Flag Coverage Δ
#linux 47.38% <ø> (ø) ⬆️
#windows 40.85% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
remotes/docker/resolver.go 58.36% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdfa49...6bfa149. Read the comment docs.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75
Copy link
Copy Markdown
Contributor

LGTM

@estesp estesp merged commit af407fb into containerd:release/1.2 Apr 19, 2019
@estesp estesp deleted the update-to-ms-image branch April 19, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants