Don't write dumped stacks to file for ETW capture state#3231
Merged
estesp merged 1 commit intocontainerd:masterfrom Apr 19, 2019
Merged
Don't write dumped stacks to file for ETW capture state#3231estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Member
Author
|
@jhowardmsft @jterry75 PTAL |
estesp
requested changes
Apr 19, 2019
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
The Linux signal handler call to dumpStacks() needs an update based on the new bool param
Signed-off-by: Kevin Parsons <[email protected]>
kevpar
force-pushed
the
dump-stacks-to-file
branch
from
c739578 to
0376dd4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3231 +/- ##
=======================================
Coverage 44.63% 44.63%
=======================================
Files 113 113
Lines 12161 12161
=======================================
Hits 5428 5428
Misses 5898 5898
Partials 835 835
Continue to review full report at Codecov.
|
Member
Author
@estesp Good catch. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ETW provides its own retention mechanism, so don't need to write out dumped stacks to file when its triggered by ETW.
Signed-off-by: Kevin Parsons [email protected]