Convert Windows CI to use Microsoft MCR image urls#3230
Merged
estesp merged 1 commit intocontainerd:masterfrom Apr 19, 2019
Merged
Convert Windows CI to use Microsoft MCR image urls#3230estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Contributor
Author
|
@jhowardmsft - FYI |
Member
|
Image reference not quite right maybe? |
Signed-off-by: Justin Terry (VM) <[email protected]>
jterry75
force-pushed
the
fix_windows_image
branch
from
67f39a0 to
e6fc0ed
Compare
Contributor
Author
|
Lol. |
Member
|
Great! The fail case is flaky one. repush it will be fine. |
lowenna
approved these changes
Apr 19, 2019
lowenna
left a comment
lowenna
left a comment
There was a problem hiding this comment.
LGTM. (The appveyor run failed for other reasons - not sure how to restart it, but you might have to commit -amend and push --force to get another run)
Codecov Report
@@ Coverage Diff @@
## master #3230 +/- ##
=======================================
Coverage 44.63% 44.63%
=======================================
Files 113 113
Lines 12161 12161
=======================================
Hits 5428 5428
Misses 5898 5898
Partials 835 835
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Terry (VM) [email protected]