[release/1.2] cherry-pick: Appveyor fixes from master#3229
Merged
crosbymichael merged 2 commits intocontainerd:release/1.2from Apr 18, 2019
Merged
[release/1.2] cherry-pick: Appveyor fixes from master#3229crosbymichael merged 2 commits intocontainerd:release/1.2from
crosbymichael merged 2 commits intocontainerd:release/1.2from
Conversation
Signed-off-by: Phil Estes <[email protected]>
Kill the underlying containerd after outputting error. Otherwise CI hangs indefinitely and requires the CI infrastructure to kill the build at the timeout expiration. Signed-off-by: Wei Fu <[email protected]> Signed-off-by: Phil Estes <[email protected]>
Member
Author
|
This fixes the |
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3229 +/- ##
============================================
Coverage 43.74% 43.74%
============================================
Files 101 101
Lines 10743 10743
============================================
Hits 4700 4700
Misses 5311 5311
Partials 732 732
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Apr 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick commits from #3222 for
release/1.2