Skip to content

Update to sha-specific nanoserver image reference to fix AppVeyor CI runs#3222

Merged
crosbymichael merged 2 commits intocontainerd:masterfrom
estesp:test-appveyor
Apr 18, 2019
Merged

Update to sha-specific nanoserver image reference to fix AppVeyor CI runs#3222
crosbymichael merged 2 commits intocontainerd:masterfrom
estesp:test-appveyor

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Apr 17, 2019 •
edited
Loading

Testing whether there is an actual problem running make integration on Windows, or whether AppVeyor is just extremely slow...

Updating nanoserver image with available exact tag; fix from @fuweid to not have CI hang in the future when this (or another image pull transient failure) happens.

Fixes: #3227

Signed-off-by: Phil Estes [email protected]

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Apr 17, 2019

Testing if #3217 is related to integration tests no longer running on AppVeyor

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Apr 17, 2019

Additional info: all current PRs in containerd are "hanging" at running integration tests, which starts a containerd daemon; output ends here:

+ integration
time="2019-04-17T14:34:13Z" level=info msg="running tests against containerd" revision=b39295f9097836c116ebc36c102612ae58ac45ee runtime= version=v1.2.0-492-gb39295f9

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Apr 17, 2019

I give up; I reverted the two commits (as a test within this PR) that precedes regular failures of AppVeyor, but even that is hanging on make integration. Scrolling through the last green AppVeyor build, all the versions and commits of dependent packages/content seem to all be the same, so it doesn't seem related to environment shifting underneath us. Any ideas @jterry75 or @jhowardmsft?

@thaJeztah thaJeztah mentioned this pull request Apr 18, 2019
Closed
@estesp estesp changed the title DO NOT MERGE: Test increased timeout for integration tests DO NOT MERGE: Test update to sha-specified nanoserver image to fix Windows runs Apr 18, 2019
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Apr 18, 2019

based on #3228 discussion and the docs from appveyor about which Docker images are present, maybe we can just use the sha-specific nanoserver image.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 18, 2019

cool. if it can pass CI, please close my pr. thanks!

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Apr 18, 2019

Green! 😅

@estesp estesp mentioned this pull request Apr 18, 2019
Closed
@estesp estesp changed the title DO NOT MERGE: Test update to sha-specified nanoserver image to fix Windows runs Update to sha-specific nanoserver image reference to fix AppVeyor CI runs Apr 18, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 18, 2019 •
edited
Loading

Codecov Report

Merging #3222 into master will decrease coverage by 4.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3222      +/-   ##
==========================================
- Coverage   48.65%   44.63%   -4.03%     
==========================================
  Files         102      113      +11     
  Lines        9569    12161    +2592     
==========================================
+ Hits         4656     5428     +772     
- Misses       4087     5898    +1811     
- Partials      826      835       +9
Flag Coverage Δ
#linux 48.65% <ø> (ø) ⬆️
#windows 39.86% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 49.51% <0%> (-5.15%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d8a05...a4942ca. Read the comment docs.

@fuweid @estesp
Fix error on pull hang in CI
a4942ca 
Kill the underlying containerd after outputting error. Otherwise CI
hangs indefinitely and requires the CI infrastructure to kill the build
at the timeout expiration.

Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Phil Estes <[email protected]>
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Apr 18, 2019

@containerd/containerd-maintainers this could use a quick review and merge as we have about 7+ PRs waiting for the ability to run AppVeyor properly which will need to rebase on this change.

fuweid
fuweid approved these changes Apr 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Apr 18, 2019

LGTM

@crosbymichael crosbymichael merged commit b819d05 into containerd:master Apr 18, 2019
@estesp estesp mentioned this pull request Apr 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

continuous-integration/appveyor/pr fails recently

4 participants

@estesp @fuweid @codecov-io @crosbymichael