Enable dumping Goroutine stacks via ETW capture state#3217
Merged
lowenna merged 2 commits intocontainerd:masterfrom Apr 15, 2019
Merged
Enable dumping Goroutine stacks via ETW capture state#3217lowenna merged 2 commits intocontainerd:masterfrom
lowenna merged 2 commits intocontainerd:masterfrom
Conversation
jterry75
approved these changes
Apr 15, 2019
Contributor
jterry75
left a comment
jterry75
left a comment
There was a problem hiding this comment.
LGTM. Not sure why Linux CI failed.
@jhowardmsft - PTAL
thaJeztah
reviewed
Apr 15, 2019
Member
There was a problem hiding this comment.
just when we got rid of some UUID implementations, a new one is added 😂 (sorry, couldn't resist)
Signed-off-by: Kevin Parsons <[email protected]>
Signed-off-by: Kevin Parsons <[email protected]>
kevpar
force-pushed
the
etw-capture-state
branch
from
3a9b312 to
78f3dc4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3217 +/- ##
=======================================
Coverage 44.63% 44.63%
=======================================
Files 113 113
Lines 12161 12161
=======================================
Hits 5428 5428
Misses 5898 5898
Partials 835 835
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
dumpStacksis called, the stacks are already logged to ETW due to the Logrus ETW hook. This change uses an ETW callback to allow triggering the stack dumping from ETW. This will make it easy to collect stacks through ETW without needing a separate utility to trigger the event object on Windows.A go-winio vendor update is needed to bring in the guid package, which is used for the ETW callback.