Correct import path and PusherFunc signature#3213
Merged
crosbymichael merged 2 commits intocontainerd:masterfrom Apr 16, 2019
jcordasc:small-fixes
Merged
Correct import path and PusherFunc signature#3213crosbymichael merged 2 commits intocontainerd:masterfrom jcordasc:small-fixes
crosbymichael merged 2 commits intocontainerd:masterfrom
jcordasc:small-fixes
Conversation
Signed-off-by: Jared Cordasco <[email protected]>
Author
|
I'm not sure what more needs to be documented for such a small miscellaneous fix PR, so if there is anything else you'd like just let me know. Thanks! |
Member
|
hi @jcordasc thanks for the update. Could you please repush again? the ci failure is caused by the flaky case. Thanks |
Signed-off-by: Jared Cordasco <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3213 +/- ##
==========================================
- Coverage 48.81% 44.76% -4.05%
==========================================
Files 102 113 +11
Lines 9538 12125 +2587
==========================================
+ Hits 4656 5428 +772
- Misses 4056 5862 +1806
- Partials 826 835 +9
Continue to review full report at Codecov.
|
bradbeam
approved these changes
Apr 16, 2019
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3212.
This PR corrects an import statement in
services/server/server_solaris.goand updates thePusherFunctype's function signature in thecontainerd/remotespackage to match thePusherinterface.