Use $TEST_RUNTIME for cri test.#3205
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Apr 12, 2019
Merged
Conversation
Member
Author
|
This can only start passing after #3203 is fixed, I guess. |
Random-Liu
force-pushed
the
test-runtime-for-cri
branch
3 times, most recently
from
8f32b92 to
9659de0
Compare
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
test-runtime-for-cri
branch
from
9659de0 to
a12f836
Compare
Codecov Report
@@ Coverage Diff @@
## master #3205 +/- ##
==========================================
- Coverage 45.19% 40.46% -4.74%
==========================================
Files 111 74 -37
Lines 12009 9954 -2055
==========================================
- Hits 5428 4028 -1400
+ Misses 5746 5360 -386
+ Partials 835 566 -269
Continue to review full report at Codecov.
|
Member
Author
|
@crosbymichael Can we get this in? So that we get shim v2 + CRI coverage before merging other changes? |
Member
|
ping @crosbymichael |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be testing runc.v1 and runc.v2 with cri test as well.
This can help us catch regressions like #3203.
Signed-off-by: Lantao Liu [email protected]