Requeue events in shim#3193
Closed
crosbymichael wants to merge 1 commit intocontainerd:masterfrom
Closed
Conversation
This also updates some of the event publishing to make things parallel and fast path finding the process on exits Signed-off-by: Michael Crosby <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3193 +/- ##
========================================
- Coverage 45.2% 40.6% -4.6%
========================================
Files 111 74 -37
Lines 11982 9906 -2076
========================================
- Hits 5416 4022 -1394
+ Misses 5732 5319 -413
+ Partials 834 565 -269
Continue to review full report at Codecov.
|
Random-Liu
reviewed
Apr 9, 2019
| go func() { | ||
| // short pause before requeue of the event | ||
| time.Sleep(100 * time.Millisecond) | ||
| s.events <- e |
Member
There was a problem hiding this comment.
Event may be out of order. It is fine, because we have timestamp on event, but we may want to keep this in mind.
Member
There was a problem hiding this comment.
Do we have any documented guarantees? Would it be useful if events were blocked on retry just for the same containerid?
Member
|
LGTM |
Member
Author
|
I want #3204 before this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also updates some of the event publishing to make things parallel
and fast path finding the process on exits
Ref #3177
Signed-off-by: Michael Crosby [email protected]