Skip to content

Introduce 'clean-test' target in Makefile#3188

Merged
estesp merged 1 commit intocontainerd:masterfrom
masters-of-cats:clean-test
Apr 5, 2019
Merged

Introduce 'clean-test' target in Makefile#3188
estesp merged 1 commit intocontainerd:masterfrom
masters-of-cats:clean-test

Conversation

@georgethebeatle
Copy link
Copy Markdown
Contributor

When tests fail they could leave debris behind such as

  • overlay mounts
  • cgroups
  • metadata
    These debris can cause subsequent tests to fail

Co-authored-by: Danail Branekov [email protected]
Signed-off-by: Georgi Sabev [email protected]

When tests fail they could leave debris behind such as
- overlay mounts
- cgroups
- metadata
These debris can cause subsequent tests to fail

Co-authored-by: Danail Branekov <[email protected]>
Signed-off-by: Georgi Sabev <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3188 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3188   +/-   ##
======================================
  Coverage    45.2%   45.2%           
======================================
  Files         111     111           
  Lines       11982   11982           
======================================
  Hits         5416    5416           
  Misses       5732    5732           
  Partials      834     834
Flag Coverage Δ
#linux 49.23% <ø> (ø) ⬆️
#windows 40.58% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 591e52c...d5b770a. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit d77a5bf into containerd:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants