Skip to content

Return event publish errors#3179

Merged
estesp merged 1 commit intocontainerd:masterfrom
Random-Liu:publish-error
Apr 5, 2019
Merged

Return event publish errors#3179
estesp merged 1 commit intocontainerd:masterfrom
Random-Liu:publish-error

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

We should return stdout/stderr from the event publish process. Only "failed to publish event" doesn't include any information for debugging.

See #3177 and #3125

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit eea500d into containerd:master Apr 5, 2019
@Random-Liu Random-Liu deleted the publish-error branch April 5, 2019 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants