Skip to content

Export ExitStatus init func#3178

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:exitStatus
Apr 4, 2019
Merged

Export ExitStatus init func#3178
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:exitStatus

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Signed-off-by: Michael Crosby [email protected]

Signed-off-by: Michael Crosby <[email protected]>
@Random-Liu
Copy link
Copy Markdown
Member

Hm, what is the context?

@crosbymichael
Copy link
Copy Markdown
Member Author

@Random-Liu This is to help with mocking client calls. Trying to port docker over to containerd and have to implement some of our interfaces with the current windows code

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Apr 4, 2019

LGTM

I think we should consider having these types of structures in subpackages though, this PR is correct but also shouldn't need to add to our client package interface.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3178   +/-   ##
=======================================
  Coverage   45.24%   45.24%           
=======================================
  Files         111      111           
  Lines       11978    11978           
=======================================
  Hits         5419     5419           
  Misses       5725     5725           
  Partials      834      834
Flag Coverage Δ
#linux 49.28% <ø> (ø) ⬆️
#windows 40.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edc733...10cf21d. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 4, 2019

Codecov Report

Merging #3178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3178   +/-   ##
=======================================
  Coverage   45.24%   45.24%           
=======================================
  Files         111      111           
  Lines       11978    11978           
=======================================
  Hits         5419     5419           
  Misses       5725     5725           
  Partials      834      834
Flag Coverage Δ
#linux 49.28% <ø> (ø) ⬆️
#windows 40.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edc733...10cf21d. Read the comment docs.

@Random-Liu
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan merged commit 9990eed into containerd:master Apr 4, 2019
@crosbymichael crosbymichael deleted the exitStatus branch April 5, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants