bump sirupsen/logrus v1.4.1#3171
Merged
estesp merged 1 commit intocontainerd:masterfrom Apr 3, 2019
Merged
Conversation
Full diff: sirupsen/logrus@v1.3.0...v1.4.1 Fixes: - Remove dependency on golang.org/x/crypto - Fix wrong method calls Logger.Print and Logger.Warningln - Update Entry.Logf to not do string formatting unless the log level is enabled - Fix infinite recursion on unknown Level.String() - Fix race condition in getCaller - Fix Entry.WithContext method to return a copy of the initial entry New: - Add DeferExitHandler, similar to RegisterExitHandler but prepending the handler to the list of handlers (semantically like defer) - Add CallerPrettyfier to JSONFormatter and `TextFormatter` - Add Entry.WithContext() and Entry.Context, to set a context on entries to be used e.g. in hooks - Enhance TextFormatter to not print caller information when they are empty Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
|
LGTM Looks like some k8s stuff is still using that terminal check from |
Member
Author
Yes, I noticed it didn't get removed here (in moby it was removed). Possibly something to check if they really needed it as well. Just thought it was good to not require a crypto package in a logger 😅 |
Codecov Report
@@ Coverage Diff @@
## master #3171 +/- ##
==========================================
- Coverage 49.21% 45.14% -4.08%
==========================================
Files 100 111 +11
Lines 9423 11971 +2548
==========================================
+ Hits 4638 5404 +766
- Misses 3960 5733 +1773
- Partials 825 834 +9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full diff: sirupsen/logrus@v1.3.0...v1.4.1
Fixes:
New:
TextFormatter