Skip to content

Update runc to resolve selinux issues#3169

Merged
dmcgowan merged 2 commits intocontainerd:masterfrom
crosbymichael:runcbump
Apr 4, 2019
Merged

Update runc to resolve selinux issues#3169
dmcgowan merged 2 commits intocontainerd:masterfrom
crosbymichael:runcbump

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael commented Apr 3, 2019

Signed-off-by: Michael Crosby [email protected]

@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 3, 2019

Looks like containerd/cri will have to update to the new selinux vendor first and update the label. calls with the new signature.

@Random-Liu
Copy link
Copy Markdown
Member

Random-Liu commented Apr 3, 2019

containerd/cri#1101 should have fixed it.

Just update cri to HEAD as well.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 3, 2019

Codecov Report

Merging #3169 into master will decrease coverage by 4.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3169      +/-   ##
==========================================
- Coverage   49.21%   45.14%   -4.08%     
==========================================
  Files         100      111      +11     
  Lines        9423    11971    +2548     
==========================================
+ Hits         4638     5404     +766     
- Misses       3960     5733    +1773     
- Partials      825      834       +9
Flag Coverage Δ
#linux 49.21% <ø> (ø) ⬆️
#windows 40.47% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9977b5...90d234e. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 3, 2019 •
edited
Loading

Codecov Report

Merging #3169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3169   +/-   ##
=======================================
  Coverage   45.14%   45.14%           
=======================================
  Files         111      111           
  Lines       11971    11971           
=======================================
  Hits         5404     5404           
  Misses       5733     5733           
  Partials      834      834
Flag Coverage Δ
#linux 49.21% <ø> (ø) ⬆️
#windows 40.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16368d...abfc89c. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Apr 3, 2019

Wait for containerd/cri#1113 as well?

@crosbymichael
Copy link
Copy Markdown
Member Author

crosbymichael commented Apr 3, 2019

@dmcgowan yes

@crosbymichael
Update runc to resolve selinux issues
4730088 
Signed-off-by: Michael Crosby <[email protected]>
@crosbymichael
Update CRI to master
abfc89c 
Signed-off-by: Michael Crosby <[email protected]>
@crosbymichael
Copy link
Copy Markdown
Member Author

crosbymichael commented Apr 4, 2019

@dmcgowan updated

estesp
estesp approved these changes Apr 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmcgowan
dmcgowan approved these changes Apr 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 4edc733 into containerd:master Apr 4, 2019
@crosbymichael crosbymichael deleted the runcbump branch April 4, 2019 19:07
This was referenced Apr 5, 2019
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crosbymichael @estesp @Random-Liu @codecov-io @dmcgowan