check alive child process when delete task#3168
Closed
lifubang wants to merge 1 commit intocontainerd:masterfrom
Closed
check alive child process when delete task#3168lifubang wants to merge 1 commit intocontainerd:masterfrom
lifubang wants to merge 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: lifubang <[email protected]>
Member
|
:( I'd rather always kill all in containerd to make it correct by default. |
Contributor
Author
|
OK, let's wait us make a decision in #3149 . |
Contributor
|
@lifubang - Is it by contract that a call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there are still shim service lock exists, we may check the container whether has alive child process or not before really delete the task. If has, raise an error to the caller to remind the user to kill all the child processes. Then the delete method without
{all: true}will not be stuck.One shim service lock case in #3149 : ( I think there are may be other cases we have not find out. )
Signed-off-by: lifubang [email protected]