Move snapshotters benchmark to a separate package#3166
Merged
estesp merged 2 commits intocontainerd:masterfrom Apr 3, 2019
Merged
Move snapshotters benchmark to a separate package#3166estesp merged 2 commits intocontainerd:masterfrom
estesp merged 2 commits intocontainerd:masterfrom
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
Go build fails on directory with only test files golang/go#8279 Signed-off-by: Maksym Pavlenko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3166 +/- ##
==========================================
+ Coverage 42.38% 45.14% +2.76%
==========================================
Files 115 111 -4
Lines 12751 11971 -780
==========================================
Hits 5404 5404
+ Misses 6513 5733 -780
Partials 834 834
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing @dmcgowan 's comment and moving benchmark code to a separate package.
Its not quite possible to split bench tests and still run them simultaneously in one command (as benchmarks complain about cli args of each other), so agreed to move it to a separate package instead.
Signed-off-by: Maksym Pavlenko [email protected]