delete the ingest when any errors happen during resuming status#3160
delete the ingest when any errors happen during resuming status#3160estesp merged 1 commit intocontainerd:masterfrom
Conversation
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
DCO check fails. you should use git commit -s to sign it off :P
There was a problem hiding this comment.
could we add log here? it will be helpful for diagnosis.
There was a problem hiding this comment.
@fuweid thank you. I add the logs printing if err != nil.
sofat1989
force-pushed
the
imageresume
branch
2 times, most recently
from
43d5122 to
0f9bc42
Compare
Codecov Report
@@ Coverage Diff @@
## master #3160 +/- ##
==========================================
+ Coverage 45.2% 45.23% +0.03%
==========================================
Files 111 111
Lines 11982 11990 +8
==========================================
+ Hits 5416 5424 +8
Misses 5732 5732
Partials 834 834
Continue to review full report at Codecov.
|
|
Please sign the commit with your full name |
|
@AkihiroSuda changed |
There was a problem hiding this comment.
Even though it is not error return, it should start with lowercase
Signed-off-by: Su Fei <[email protected]>
|
@AkihiroSuda PTAL |
5 participants
Fix: #3089