runtime/v1/linux/proc/io: io race#3153
Merged
crosbymichael merged 2 commits intocontainerd:masterfrom Apr 1, 2019
thepwagner:issue-3118
Merged
runtime/v1/linux/proc/io: io race#3153crosbymichael merged 2 commits intocontainerd:masterfrom thepwagner:issue-3118
crosbymichael merged 2 commits intocontainerd:masterfrom
thepwagner:issue-3118
Conversation
Signed-off-by: Peter Wagner <[email protected]>
Signed-off-by: Peter Wagner <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3153 +/- ##
==========================================
- Coverage 49.25% 45.16% -4.09%
==========================================
Files 100 111 +11
Lines 9415 11962 +2547
==========================================
+ Hits 4637 5403 +766
- Misses 3955 5727 +1772
- Partials 823 832 +9
Continue to review full report at Codecov.
|
Member
|
LGTM |
Member
|
do we need to backport this to the 1.1/1.2 release branches? |
Member
|
@thaJeztah yes |
Member
|
I'll do a quick cherry-pick 👍 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #3118 by introducing synchronization to the
wc.Close()calls.WarnlevelWriteClosertoClose()