I would suggest putting the CF template somewhere in contrib/ just to clarify it isn't a supported part of containerd

@estesp done

Codecov Report

Merging #3152 into master will decrease coverage by 8.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3152      +/-   ##
==========================================
- Coverage   49.25%   40.49%   -8.76%     
==========================================
  Files         100       74      -26     
  Lines        9415     9898     +483     
==========================================
- Hits         4637     4008     -629     
- Misses       3955     5324    +1369     
+ Partials      823      566     -257

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0a06d...d9526f5. Read the comment docs.

LGTM

I think having these tests are a good idea, but I would prefer the testsuite package not divert from the suite approach. Benchmarks can be implemented in the same way as unit tests and the individual packages can run their own instance of benchmarks. That prevents a single test package needing to import all the snapshotters. You can still run multiple packages in one command still go test -bench=. ./snapshots/overlay ./snapshots/devmapper

@dmcgowan that's reasonable. is it fine to put common benchmark code to snapshots/ directory than?

The common benchmark code in snapshots/testsuite is fine. The main difference from the unit tests here seems to be how the root is configured, but that could be smarter to allow the individual tests to set a base root.

Updating the unit tests code to support this could be nice too if it is useful for devmapper to use the tests to verify the devmapper configuration.

Ok, I'll submit another PR for this.