Skip to content

bump containerd/cgroups 4994991857f9b0ae8dc439551e8bebdbb4bf66c1#3142

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_cgroups
Mar 29, 2019
Merged

bump containerd/cgroups 4994991857f9b0ae8dc439551e8bebdbb4bf66c1#3142
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_cgroups

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

full diff: containerd/cgroups@dbea6f2...4994991

brings in containerd/cgroups#79 Return ErrCgroupDeleted when no subsystems
fixes #3133 Custom cgroup path does not work in containerd 1.2.5

full diff: containerd/cgroups@dbea6f2...4994991

brings in containerd/cgroups#79 Return ErrCgroupDeleted when no subsystems
fixes containerd#3133 Custom cgroup path does not work in containerd 1.2.5

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

@crosbymichael @dmcgowan PTAL

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3142   +/-   ##
=======================================
  Coverage   43.59%   43.59%           
=======================================
  Files         104      104           
  Lines       11159    11159           
=======================================
  Hits         4865     4865           
  Misses       5555     5555           
  Partials      739      739
Flag Coverage Δ
#linux 47.59% <ø> (ø) ⬆️
#windows 40.49% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a20ea...2b8df83. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3142   +/-   ##
=======================================
  Coverage   43.59%   43.59%           
=======================================
  Files         104      104           
  Lines       11159    11159           
=======================================
  Hits         4865     4865           
  Misses       5555     5555           
  Partials      739      739
Flag Coverage Δ
#linux 47.59% <ø> (ø) ⬆️
#windows 40.49% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a20ea...2b8df83. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 86cfcb8 into containerd:master Mar 29, 2019
@thaJeztah thaJeztah deleted the bump_cgroups branch March 29, 2019 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom cgroup path does not work in containerd 1.2.5

4 participants