Compress import blobs in Docker compatibility code#3135
Compress import blobs in Docker compatibility code#3135estesp merged 1 commit intocontainerd:masterfrom
Conversation
There was a problem hiding this comment.
the filter functionality is TODO item right now.
There was a problem hiding this comment.
ugh... well as long as this code doesn't panic, just shouldn't assume then that the result is non empty. Maybe an ok check on labels would be safer.
There was a problem hiding this comment.
You are referring to the local implementation, the metadata store that will normally be used handles it. Either way, the implementation should always handle the case where the filter wasn't applied.
|
One test failing; |
dmcgowan
force-pushed
the
archive-importer-docker-types
branch
from
91e7f40 to
d487167
Compare
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
=======================================
Coverage 45.24% 45.24%
=======================================
Files 111 111
Lines 11978 11978
=======================================
Hits 5419 5419
Misses 5725 5725
Partials 834 834
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
"failed to truncate writer`?
There was a problem hiding this comment.
not specific to this PR, but we should have const and godoc for labels
There was a problem hiding this comment.
Not necessary, these are errors which should never occur but I much prefer panic to assigning to _
Ensure the manifest which gets created using the Docker compatibility code compresses the blob before creating the manifest. This ensures consistency with manifests used by Docker. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
archive-importer-docker-types
branch
from
d487167 to
8d1ae23
Compare
6 participants
Ensure the manifest which gets created using the Docker compatibility code compresses the blob before creating the manifest. This ensures consistency with manifests generated by Docker.