Windows: appveyor: Build shim binary from Microsoft/hcsshim repo#3128
Merged
jterry75 merged 2 commits intocontainerd:masterfrom Mar 26, 2019
Merged
Windows: appveyor: Build shim binary from Microsoft/hcsshim repo#3128jterry75 merged 2 commits intocontainerd:masterfrom
jterry75 merged 2 commits intocontainerd:masterfrom
Conversation
lowenna
force-pushed
the
jjh/ci
branch
7 times, most recently
from
6a93bc0 to
6af44fc
Compare
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
jjh/ci
branch
15 times, most recently
from
c55af66 to
8040e2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
+ Coverage 43.58% 47.57% +3.99%
==========================================
Files 104 93 -11
Lines 11156 8608 -2548
==========================================
- Hits 4862 4095 -767
+ Misses 5555 3783 -1772
+ Partials 739 730 -9
Continue to review full report at Codecov.
|
lowenna
force-pushed
the
jjh/ci
branch
6 times, most recently
from
fde27da to
97065bc
Compare
lowenna
force-pushed
the
jjh/ci
branch
8 times, most recently
from
af139b7 to
c385ffc
Compare
Signed-off-by: John Howard <[email protected]> This is part of a phased update to remove the existing Windows shim code from the containerd repo, and instead use the one from Microsoft/hcsshim.
lowenna
changed the title
Author
|
@jterry75 @dmcgowan @crosbymichael PTAL. |
Contributor
|
Thanks @jhowardmsft! This is a great first step! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
This is a phased approach to removing the existing "v1" shim code for Windows from the containerd repo in preparation for v1.3. This first step ensures that the shim (and runhcs.exe although that will be removed later) are built during CI from the commit of hcsshim in the vendor.conf file.
Note that although built, this first step does not update the test scripts execution lines to include the path of the built binaries, so they will still use the shim binary build from the containerd/containerd repo.