Skip to content

Extend adaptImage function with annotations case#3122

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
stefanberger:descriptor_annotations.pr
Mar 22, 2019
Merged

Extend adaptImage function with annotations case#3122
dmcgowan merged 1 commit intocontainerd:masterfrom
stefanberger:descriptor_annotations.pr

Conversation

@stefanberger
Copy link
Copy Markdown
Contributor

Extend the adaptImage function with a case for handling the annotations
so they can be used in the filter adaptors for fieldpaths.

This PR addresses issue #3121.

Signed-off-by: Stefan Berger [email protected]

Extend the adaptImage function with a case for handling the annotations
so they can be used in the filter adaptors for fieldpaths.

Signed-off-by: Stefan Berger <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3122 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3122      +/-   ##
==========================================
- Coverage   43.58%   43.58%   -0.01%     
==========================================
  Files         104      104              
  Lines       11154    11156       +2     
==========================================
  Hits         4862     4862              
- Misses       5553     5555       +2     
  Partials      739      739
Flag Coverage Δ
#linux 47.57% <0%> (-0.02%) ⬇️
#windows 40.47% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
metadata/adaptors.go 40.47% <0%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b882c4...5d50b9c. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

1 similar comment
@dmcgowan
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan merged commit 68c44f8 into containerd:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants