Skip to content

Allow to import an image for the default platform only.#3108

Merged
estesp merged 1 commit intocontainerd:masterfrom
alculquicondor:fix/import
Mar 19, 2019
Merged

Allow to import an image for the default platform only.#3108
estesp merged 1 commit intocontainerd:masterfrom
alculquicondor:fix/import

Conversation

@alculquicondor
Copy link
Copy Markdown
Contributor

Add all-platforms option to ctr images import.

Fixes #3103

Copy link
Copy Markdown
Contributor

@erain erain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread cmd/ctr/commands/images/import.go Outdated
@erain
Copy link
Copy Markdown
Contributor

erain commented Mar 19, 2019

@Random-Liu could you help review this?

@estesp
Copy link
Copy Markdown
Member

estesp commented Mar 19, 2019

Thanks for the contribution! Your commit needs to be signed to pass CI; usually git commit --amend -s followed by git push -f will do the trick, as long as your git config includes your name and email address.

Add `all-platforms` option to `ctr images import`.

Signed-off-by: Aldo Culquicondor <[email protected]>
@alculquicondor
Copy link
Copy Markdown
Contributor Author

Done. Sorry I missed that!

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3108   +/-   ##
=======================================
  Coverage   43.59%   43.59%           
=======================================
  Files         104      104           
  Lines       11135    11135           
=======================================
  Hits         4854     4854           
  Misses       5545     5545           
  Partials      736      736
Flag Coverage Δ
#linux 47.57% <ø> (ø) ⬆️
#windows 40.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90eead...9a8727c. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants