Skip to content

decouple api.ContentServer implementation package from bbolt dependency#3104

Merged
estesp merged 1 commit intocontainerd:masterfrom
AkihiroSuda:split-contentserver
Mar 21, 2019
Merged

decouple api.ContentServer implementation package from bbolt dependency#3104
estesp merged 1 commit intocontainerd:masterfrom
AkihiroSuda:split-contentserver

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Mar 19, 2019

For moby/buildkit#886

Signed-off-by: Akihiro Suda [email protected]

cc @thaJeztah @tonistiigi

@AkihiroSuda AkihiroSuda mentioned this pull request Mar 19, 2019
Closed
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Mar 19, 2019 •
edited
Loading

This PR just splits the package so that New(content.Store) api.ContentServer can be imported without dependency on bbolt package
No substantial change on the code.

@AkihiroSuda AkihiroSuda force-pushed the split-contentserver branch from d53c448 to f3ff95a Compare March 19, 2019 07:09
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 19, 2019

Codecov Report

Merging #3104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3104   +/-   ##
=======================================
  Coverage   43.59%   43.59%           
=======================================
  Files         104      104           
  Lines       11135    11135           
=======================================
  Hits         4854     4854           
  Misses       5545     5545           
  Partials      736      736
Flag Coverage Δ
#linux 47.57% <ø> (ø) ⬆️
#windows 40.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90eead...f3ff95a. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Mar 19, 2019

LGTM

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Mar 20, 2019

basically, LGTM

just thinking about the package name. contentservice package is located in content folder and prefix content is duplicate. just random thought. :P

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Mar 21, 2019

io/ioutil :P

fuweid
fuweid reviewed Mar 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Mar 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit ceba568 into containerd:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid left review comments

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AkihiroSuda @codecov-io @crosbymichael @fuweid @estesp