Skip to content

ctr: fix image cmd ArgsUsage#3102

Merged
estesp merged 1 commit intocontainerd:masterfrom
Ace-Tang:arg_usage
Mar 18, 2019
Merged

ctr: fix image cmd ArgsUsage#3102
estesp merged 1 commit intocontainerd:masterfrom
Ace-Tang:arg_usage

Conversation

@Ace-Tang
Copy link
Copy Markdown
Contributor

ctr image list/check 's ArgsUsage should be filter, not ref

Signed-off-by: Ace-Tang [email protected]

ctr image list/check 's ArgsUsage should be filter, not ref

Signed-off-by: Ace-Tang <[email protected]>
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3102 into master will decrease coverage by 3.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
- Coverage   47.57%   43.59%   -3.99%     
==========================================
  Files          93      104      +11     
  Lines        8590    11135    +2545     
==========================================
+ Hits         4087     4854     +767     
- Misses       3776     5545    +1769     
- Partials      727      736       +9
Flag Coverage Δ
#linux 47.57% <ø> (ø) ⬆️
#windows 40.47% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c60a5fd...14a0506. Read the comment docs.

@estesp estesp merged commit b90eead into containerd:master Mar 18, 2019
@Ace-Tang Ace-Tang deleted the arg_usage branch March 19, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants